Add methods + tests for host muting #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wang-arthur
force-pushed
the
add_host_muting
branch
from
8febf2e to
83300e5
Compare
| @@ -231,6 +231,33 @@ def get_all_downtimes(options = {}) | |||
| end | |||
| end | |||
|
|
|||
| # | |||
| # HOST MUTING | |||
There was a problem hiding this comment.
Shall we have a separate host.rb file ?
There was a problem hiding this comment.
I think that would make sense if we interact with Hosts as objects - it appears that these methods are added to interact with the /monitor api interface.
There was a problem hiding this comment.
Indeed; this endpoint is actually a convenience wrapper around downtime scheduling.
|
Great, thanks @wang-arthur. Looks ready to go to me. |
wang-arthur
pushed a commit
that referenced
this pull request
May 27, 2015
Add methods + tests for host muting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.