Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hosts API #152

Merged
merged 4 commits into from
Apr 27, 2018
Merged

Add hosts API #152

merged 4 commits into from
Apr 27, 2018

Conversation

samanthadrago
Copy link
Contributor

@samanthadrago samanthadrago commented Apr 16, 2018 •
edited
Loading

Add hosts endpoints:
-search_hosts
-host_totals

Also adds deprecation warning to search endpoint to steer users toward new search_hosts endpoint instead.

@samanthadrago samanthadrago force-pushed the samantha/hosts_api branch 2 times, most recently from 9a386e0 to 2b5008b Compare April 18, 2018 14:51
@samanthadrago samanthadrago mentioned this pull request Apr 18, 2018
Merged
gmmeyer
gmmeyer approved these changes Apr 27, 2018
View reviewed changes
Copy link

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty happy with this change!

Thanks a lot @samanthadrago!

@pietdaniel pietdaniel merged commit 7e86c62 into master Apr 27, 2018
@masci masci deleted the samantha/hosts_api branch June 5, 2018 06:51
@masci masci added this to the 1.30 milestone Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
4 participants
@samanthadrago @gmmeyer @masci @pietdaniel