Skip to content

Commit

Permalink
Merge pull request #136 from DataDog/hao/screenboard-share-api-change
Browse files Browse the repository at this point in the history
change http-method GET to POST on api.Screenboard#share
  • Loading branch information
haohcraft authored Oct 27, 2017
2 parents 83c5b18 + 8ee4464 commit ed593e2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/dogapi/v1/screenboard.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def delete_screenboard(board_id)
end

def share_screenboard(board_id)
request(Net::HTTP::Get, "/api/#{API_VERSION}/screen/share/#{board_id}", nil, nil, false)
request(Net::HTTP::Post, "/api/#{API_VERSION}/screen/share/#{board_id}", nil, nil, false)
end

def revoke_screenboard(board_id)
Expand Down
2 changes: 1 addition & 1 deletion spec/integration/screenboard_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
describe '#share_screenboard' do
it_behaves_like 'an api method',
:share_screenboard, [BOARD_ID],
:get, "/screen/share/#{BOARD_ID}"
:post, "/screen/share/#{BOARD_ID}"
end

describe '#revoke_screenboard' do
Expand Down

0 comments on commit ed593e2

Please sign in to comment.