Skip to content

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Oct 5, 2025

What does this PR do? What is the motivation?

  • Add information about pipeline permissions
  • DOCS-12200

Merge instructions

Merge readiness:

Do not merge Pending PM approval

@estherk15 estherk15 requested a review from a team as a code owner October 5, 2025 23:28
Copy link
Contributor

github-actions bot commented Oct 5, 2025

@maycmlee maycmlee self-assigned this Oct 6, 2025
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Just a couple of small edits and for some reason in the preview, I'm seeing this parts seems to be cut off:
2025-10-06_13-12-16

Also, do you need to add an entry to the table on the Granular Access Control page? https://docs-staging.datadoghq.com/esther/docs-12138-pipeline-rbac/logs/log_configuration/pipelines/?tab=source

Co-authored-by: May Lee <may.lee@datadoghq.com>
@estherk15
Copy link
Contributor Author

estherk15 commented Oct 6, 2025

Hey @maycmlee I think the cutoff is word wrapping? The full sentence is there, but let me know if you mean something else. Also, for GRACE I'll reach out to Ursula, I don't think all of Logs Management transitioned to it. Thanks for calling that out!

@maycmlee
Copy link
Contributor

maycmlee commented Oct 6, 2025

@estherk15 🤦‍♀️ the bolded part of the sentence threw me off. Scrap what I said about that preview. For the GRACE table, it's not auto-generated...I only know because I recently had to add to it.

@makenzie-dd
Copy link
Contributor

makenzie-dd commented Oct 6, 2025

Hey Esther! Some quick comments:

  • I'm not sure users will know what the "scoped RBAC feature flag" will mean. We may need to elaborate more? There isn't an official name, but in the UI when you open a new pipeline or an existing pipeline's config, it is currently step 2, access control, "Grant editing processors of this pipeline to". Attaching a screenshot for context
Screenshot 2025-10-06 at 2 56 34 PM
  • "Restricted pipeline editor" is a bit confusing imo. I think we may need a bit more information here on what restricting a pipeline looks like and means, and then the permissions within a restricted pipeline?
  • Pipeline editor still gives you permission to modify processors which isn't clear here
  • We may need to add in here that granting a user access to a pipeline's restriction list does not automatically grant them the logs_write_pipelines or logs_write_processors permissions, and if they don't already have the proper permissions, an admin will need to go do that.

I think a few screenshots (or at least 1) may help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants