[PROF-9088] Ensure DSO objects are cleared #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It no longer has a PID container It is embedded in a process object
r1viollet
force-pushed
the
r1viollet/fix_leak_dso
branch
from
056210a to
d3128f0
Compare
r1viollet
commented
Apr 4, 2024
| void add_error_frame(const Dso *dso, UnwindState *us, | ||
| [[maybe_unused]] ProcessAddress_t pc, | ||
| SymbolErrors error_case) { | ||
| ddprof_stats_add(STATS_UNWIND_ERRORS, 1, nullptr); |
There was a problem hiding this comment.
the unwinding error stats was computed on symbolization failures sometimes.
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
r1viollet
force-pushed
the
r1viollet/fix_leak_dso
branch
from
3cc7706 to
9707a09
Compare
r1viollet
changed the title
r1viollet
commented
Apr 7, 2024
r1viollet
force-pushed
the
r1viollet/fix_leak_dso
branch
from
0725404 to
2aefb65
Compare
r1viollet
force-pushed
the
r1viollet/fix_leak_dso
branch
from
2aefb65 to
5c00dcc
Compare
nsavoire
reviewed
Apr 8, 2024
nsavoire
reviewed
Apr 8, 2024
src/unwind.cc
Outdated
| @@ -59,32 +59,46 @@ void unwind_init_sample(UnwindState *us, const uint64_t *sample_regs, | |||
|
|
|||
| DDRes unwindstate_unwind(UnwindState *us) { | |||
| DDRes res = ddres_init(); | |||
| Process &process = us->process_hdr.get(us->pid); | |||
| bool avoid_new_attach = false; | |||
| if (us->process_hdr.process_count() > us->max_pids) { | |||
There was a problem hiding this comment.
process_count() might not be equal to the number of attached dwfl objects.
There was a problem hiding this comment.
I am not pushing this further as making the control perfect will take quite an extra bit of work. I understand the current limitations.
nsavoire
reviewed
Apr 8, 2024
nsavoire
reviewed
Apr 8, 2024
| private: | ||
| static std::string format_cgroup_file(pid_t pid, | ||
| std::string_view path_to_proc); | ||
|
|
||
| static DDRes read_cgroup_ns(pid_t pid, std::string_view path_to_proc, | ||
| CGroupId_t &cgroup); | ||
|
|
||
| std::unique_ptr<DwflWrapper> _dwfl_wrapper{}; |
There was a problem hiding this comment.
Suggested change
| std::unique_ptr<DwflWrapper> _dwfl_wrapper{}; | |
| std::unique_ptr<DwflWrapper> _dwfl_wrapper; |
There was a problem hiding this comment.
I did not have an opinion on this. Leaving as is unless we push for a different guideline. Feel free to challenge me further if this is important.
nsavoire
reviewed
Apr 8, 2024
nsavoire
reviewed
Apr 8, 2024
nsavoire
reviewed
Apr 8, 2024
nsavoire
reviewed
Apr 8, 2024
nsavoire
previously approved these changes
Apr 8, 2024
r1viollet
force-pushed
the
r1viollet/fix_leak_dso
branch
from
b5b82ef to
9a07ff9
Compare
nsavoire
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
We were seeing a large heap usage with the DSO objects.
Indeed prior to this PR we were not considering the existing DSOs that had no unwinding (dwfl) objects.
Additional Notes
NA
How to test the change?
We should test the RSS improvements on full host applications.