Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code locations by default #398

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

r1viollet
Copy link
Collaborator

What does this PR do?

There seems to be an excessive RSS usage with the usage of debug information. This is an experiment to see what is the cost of debug information with blazesym.

Motivation

Understand the cost of debug information.

Additional Notes

The Inlinie feature still allows to access code location feature.

How to test the change?

The aim is to see what this yields in staging applications.

Copy link
Collaborator

@nsavoire nsavoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There seems to be an excessive RSS usage with the usage of debug information.
This is an experiment to see what is the cost of debug information with blazesym.
@r1viollet r1viollet force-pushed the r1viollet/change_default_symbolization branch from 3cd83a4 to ea06b91 Compare March 29, 2024 13:54
@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2024

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+e6a1ad9f.31102042 ddprof 0.17.0+ea06b91d.31105090

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2024

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+e6a1ad9f.31102042 ddprof 0.17.0+ea06b91d.31105090

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet r1viollet merged commit 5f192d1 into main Mar 29, 2024
2 checks passed
@r1viollet r1viollet deleted the r1viollet/change_default_symbolization branch March 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants