Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CLI update - Allow hyphens and underscores #397

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

r1viollet
Copy link
Collaborator

What does this PR do?

Allow hyphens and underscores

Motivation

I was often confused when using the CLI options.

Additional Notes

N/A

How to test the change?

N/A

@r1viollet r1viollet force-pushed the r1viollet/config_convenience branch from 144c326 to b0e67f7 Compare March 29, 2024 13:17
@r1viollet r1viollet marked this pull request as ready for review March 29, 2024 13:17
@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2024

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+1fedffb2.31099498 ddprof 0.17.0+b0e67f7c.31100379

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2024

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+1fedffb2.31099498 ddprof 0.17.0+b0e67f7c.31100379

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet r1viollet merged commit e6a1ad9 into main Mar 29, 2024
2 checks passed
@r1viollet r1viollet deleted the r1viollet/config_convenience branch March 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants