Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-9429] Search profiler mount namespace first #393

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Mar 26, 2024

What does this PR do?

When looking for file corresponding to a mapping, first look in profiler mount namespace and if absent then look in /proc/<pid>/root.
In the case of short lived processes, path in profiler mount namespace will still be accessible after process exit.

@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2024

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+3e7ad738.30812730 ddprof 0.17.0+70935f97.30817536

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2024

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+3e7ad738.30812730 ddprof 0.17.0+70935f97.30817536

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

When looking for file corresponding to a mapping, first
look in profiler mount namespace and if absent then
look in /proc/<pid>/root.
In the case of short lived processes, path in profiler
mount namespace will still be accessible after process
exit.
@nsavoire nsavoire force-pushed the nsavoire/use_profiler_mount_namespace_in_priority branch from 23ae6a6 to 70935f9 Compare March 26, 2024 11:01
@nsavoire nsavoire changed the title Search profiler mount namespace in priority Search profiler mount namespace first Mar 26, 2024
@nsavoire nsavoire changed the title Search profiler mount namespace first [PROF-9429] Search profiler mount namespace first Mar 26, 2024
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I agree! stable paths > unstable paths

@nsavoire nsavoire merged commit fb04551 into main Mar 27, 2024
2 checks passed
@nsavoire nsavoire deleted the nsavoire/use_profiler_mount_namespace_in_priority branch March 27, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants