Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROF-9088] Add option to disable symbolization #380

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[PROF-9088] Add option to disable symbolization #380

merged 1 commit into from
Feb 22, 2024

Conversation

nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Feb 16, 2024 •
edited
Loading

Motivation

Allow to completely disable symbolization so as to easily measure its memory / cpu overhead.

@pr-commenter
Copy link

pr-commenter bot commented Feb 16, 2024

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.16.0+308e9a1c.28406989 ddprof 0.16.0+20bf3f50.28435556

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Feb 16, 2024

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.16.0+308e9a1c.28406989 ddprof 0.16.0+20bf3f50.28435556

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

r1viollet
r1viollet approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please improve motivation section before merging.
Thank you 🙇

@nsavoire nsavoire merged commit 7730467 into main Feb 22, 2024
2 checks passed
@nsavoire nsavoire deleted the nsavoire/disable_symbolization_flag branch February 22, 2024 10:22
@r1viollet r1viollet changed the title Add option to disable symbolization [PROF-9088] Add option to disable symbolization Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r1viollet r1viollet r1viollet approved these changes

@sanchda sanchda Awaiting requested review from sanchda sanchda is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsavoire @r1viollet