Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROF-9088] Add an hidden option to enable remote symbolization #375

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[PROF-9088] Add an hidden option to enable remote symbolization #375

merged 1 commit into from
Feb 6, 2024

Conversation

nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Feb 5, 2024 •
edited
Loading

Enabling remote symbolization with --remote-symbolization currently has 2 effects

  • use elf addresses instead of process addresses in exported pprof
  • add a remote_symbols:yes tag

@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2024 •
edited
Loading

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.3+2c27bc0a.27603583 ddprof 0.15.3+9ac6e53f.27704969

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2024 •
edited
Loading

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.3+2c27bc0a.27603583 ddprof 0.15.3+9ac6e53f.27704969

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@nsavoire nsavoire requested a review from peterg17 February 5, 2024 12:58
@nsavoire
Add an hidden option to enable remote symbolization
9ac6e53 
Enabling remote symbolization currently has 2 effects
* use elf addresses instead of process addresses in exported pprof
* add a `remote_symbols:yes` tag
@nsavoire nsavoire force-pushed the nsavoire/remote_symbolization branch from 5f25f84 to 9ac6e53 Compare February 5, 2024 13:32
r1viollet
r1viollet approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsavoire nsavoire merged commit 0a0dfa3 into main Feb 6, 2024
2 checks passed
@nsavoire nsavoire deleted the nsavoire/remote_symbolization branch February 6, 2024 13:07
peterg17
peterg17 reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@peterg17 peterg17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@r1viollet r1viollet changed the title Add an hidden option to enable remote symbolization [PROF-9088] Add an hidden option to enable remote symbolization Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterg17 peterg17 peterg17 left review comments

@r1viollet r1viollet r1viollet approved these changes

@sanchda sanchda Awaiting requested review from sanchda sanchda is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsavoire @peterg17 @r1viollet