Add logging to the library #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nsavoire
commented
Jan 11, 2024
•
nsavoire
commented
- Setup logger in library
- Use DD_PROFILING_NATIVE_LIBRARY_LOG_MODE with fallback to DD_PROFILING_NATIVE_LOG_MODE to determine library log mode
- Use DD_PROFILING_NATIVE_LIBRARY_LOG_LEVEL with fallback to DD_PROFILING_NATIVE_LOG_LEVEL to determine library log level
- Add callback in logger to determine if log is allowed, this callback is used to disable logging when allocations are forbidden
nsavoire
force-pushed
the
nsavoire/logging_in_library
branch
2 times, most recently
from
fee1626 to
b55c53b
Compare
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
r1viollet
previously approved these changes
Jan 12, 2024
nsavoire
force-pushed
the
nsavoire/avoid_allocations_in_mmap_hooks
branch
from
86873df to
91adb83
Compare
Base automatically changed from
nsavoire/avoid_allocations_in_mmap_hooks
to
main
January 12, 2024 15:35
r1viollet
reviewed
Jan 19, 2024
src/lib/allocation_tracker.cc
Outdated
| if (_state.pid == 0) { | ||
| _state.pid = getpid(); | ||
| } | ||
| if (tl_state.tid == 0) { |
There was a problem hiding this comment.
maybe leaving a cassert is nice
nsavoire
force-pushed
the
nsavoire/logging_in_library
branch
6 times, most recently
from
a7eadd5 to
fbd0b92
Compare
r1viollet
reviewed
Feb 13, 2024
| #else | ||
| // DDPROF_CHECK_FATAL must not be used inside profiling library | ||
| # define DDPROF_CHECK_FATAL(condition, ...) \ | ||
| static_assert( \ |
nsavoire
force-pushed
the
nsavoire/logging_in_library
branch
from
fbd0b92 to
26c39e0
Compare
nsavoire
force-pushed
the
nsavoire/logging_in_library
branch
from
26c39e0 to
6ec12ac
Compare
* Setup logger in library * Use DD_PROFILING_NATIVE_LIBRARY_LOG_MODE with fallback to DD_PROFILING_NATIVE_LOG_MODE to determine library log mode * Use DD_PROFILING_NATIVE_LIBRARY_LOG_LEVEL with fallback to DD_PROFILING_NATIVE_LOG_LEVEL to determine library log level * Add callback in logger to determine if log is allowed, this callback is used to disable logging when allocations are forbidden
nsavoire
force-pushed
the
nsavoire/logging_in_library
branch
2 times, most recently
from
a0e82a7 to
f8c1438
Compare
Using arrays made the code incorrect when embedded data was not present, since their addresses and the resulting computed size would be non-NULL.
nsavoire
force-pushed
the
nsavoire/logging_in_library
branch
from
f8c1438 to
9790fe1
Compare
|
@r1viollet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.