Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless malloc/free calls #355

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Remove useless malloc/free calls #355

merged 1 commit into from
Jan 12, 2024

Conversation

nsavoire
Copy link
Collaborator

What does this PR do?

Since malloc wrappers are not used anymore, these call are not needed anymore.

@nsavoire
Remove useless malloc/free calls
3436cba 
Since malloc wrappers are not used anymore, these call are not needed
anymore.
@pr-commenter
Copy link

pr-commenter bot commented Jan 11, 2024

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.1+ab350845.26328077 ddprof 0.15.1+3436cbab.26328379

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Jan 11, 2024

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.1+ab350845.26328077 ddprof 0.15.1+3436cbab.26328379

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

r1viollet
r1viollet approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsavoire nsavoire merged commit 0e693d9 into main Jan 12, 2024
2 checks passed
@nsavoire nsavoire deleted the nsavoire/remove_useless_malloc_free_calls branch January 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r1viollet r1viollet r1viollet approved these changes

@sanchda sanchda Awaiting requested review from sanchda sanchda is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsavoire @r1viollet