Logger rate limiting #343
Merged
Logger rate limiting #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
force-pushed
the
nsavoire/logger_rate_limiting
branch
from
7e8cb11 to
63a5d9b
Compare
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
r1viollet
previously approved these changes
Nov 14, 2023
r1viollet
reviewed
Nov 14, 2023
| namespace ddprof { | ||
| void setup_logger(const char *log_mode, const char *log_level); | ||
| } | ||
| inline constexpr auto kMaxLogPerSecForNonDebug = 100; |
sanchda
previously approved these changes
Nov 14, 2023
nsavoire
force-pushed
the
nsavoire/logger_rate_limiting
branch
from
d2c4947 to
385b371
Compare
sanchda
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement log rate limiting when log level is above debug. Rate limit is set at 100 log/s.