Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable return #331

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Remove unreachable return #331

merged 1 commit into from
Oct 20, 2023

Conversation

sanchda
Copy link
Collaborator

@sanchda sanchda commented Oct 19, 2023

Remove unreachable return.

What does this PR do?

Removes an unreachable return.

Motivation

Returns should be reachable. A return which is unreachable cannot be reached, so it can be confusing when people try to reach it.

Additional Notes

When a return is unreachable, nobody can reach it.

How to test the change?

There is NO WAY to test this change, do not try.

Remove unreachable return.
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nsavoire nsavoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David is back ❤️

@pr-commenter
Copy link

pr-commenter bot commented Oct 19, 2023

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.0+d0e1d417.21644398 ddprof 0.15.0+6456ea58.22030615

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh unsure
[-58.081ms; -26.560ms] or [-1.503%; -0.688%]

@pr-commenter
Copy link

pr-commenter bot commented Oct 19, 2023

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.0+d0e1d417.21644398 ddprof 0.15.0+6456ea58.22030615

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet r1viollet merged commit 0caad0a into main Oct 20, 2023
@r1viollet r1viollet deleted the sanchda/fixret branch October 20, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants