Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the flakyiess of simple_malloc #324

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

r1viollet
Copy link
Collaborator

What does this PR do?

Change niceness level of the simple malloc process
This ensure that ddprof is scheduled with a higher priority.

Motivation

Less flaky tests.

Add an option to override the niceness level of simple malloc
@r1viollet r1viollet marked this pull request as ready for review October 9, 2023 15:53
test/simple_malloc.cc Outdated Show resolved Hide resolved
nsavoire
nsavoire previously approved these changes Oct 10, 2023
Ensure default niceness is 0 and that the unit test overrides it to 19
@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2023

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.0+4701e9d7.21460863 ddprof 0.15.0+a1813c10.21464921

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2023

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.0+4701e9d7.21460863 ddprof 0.15.0+a1813c10.21464921

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 unsure
[+5.947ms; +12.645ms] or [+0.241%; +0.512%]

@r1viollet r1viollet requested a review from nsavoire October 11, 2023 09:30
@r1viollet r1viollet merged commit 11242b8 into main Oct 11, 2023
@r1viollet r1viollet deleted the r1viollet/flaky_test_fix branch October 11, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants