Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddprof cli - port env var fix #286

Merged
merged 2 commits into from
Jul 11, 2023
Merged

ddprof cli - port env var fix #286

merged 2 commits into from
Jul 11, 2023

Conversation

r1viollet
Copy link
Collaborator

What does this PR do?

During the ddprof CLI refactoring, I introduced a regression. This reintroduces the DD_TRACE_AGENT_PORT environement variable.

Motivation

Fix staging deployments that rely on this variable.

During the ddprof CLI refactoring, I introduced a regression.
This reintroduces the DD_TRACE_AGENT_PORT environement variable.
Refresh the help documentation
sanchda
sanchda previously approved these changes Jul 11, 2023
Copy link
Collaborator

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r1viollet r1viollet merged commit 97f592d into main Jul 11, 2023
@r1viollet r1viollet deleted the r1viollet/fix_port_env_var branch July 11, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants