Refactoring of CLI options #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1viollet
force-pushed
the
r1viollet/ddprof_cli
branch
5 times, most recently
from
1e69537 to
199cc90
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
r1viollet
force-pushed
the
r1viollet/ddprof_cli
branch
from
2aa1b2a to
298c39e
Compare
r1viollet
commented
Jun 20, 2023
r1viollet
force-pushed
the
r1viollet/ddprof_cli
branch
from
1993195 to
4b7e337
Compare
r1viollet
changed the title
r1viollet
commented
Jun 21, 2023
r1viollet
commented
Jun 21, 2023
r1viollet
commented
Jun 21, 2023
r1viollet
force-pushed
the
r1viollet/ddprof_cli
branch
2 times, most recently
from
c6e0a1f to
b6eb5ff
Compare
sanchda
reviewed
Jun 23, 2023
r1viollet
commented
Jun 23, 2023
r1viollet
force-pushed
the
r1viollet/ddprof_cli
branch
4 times, most recently
from
1a5d395 to
5ec7cb7
Compare
nsavoire
reviewed
Jun 27, 2023
- Restructure the documentation - Add CLI11 as a library to parse arguments This makes it safer and ensures a proper error message is surfaced to users. - Remove C types in favor of C++ types - Introduce configuration files
r1viollet
force-pushed
the
r1viollet/ddprof_cli
branch
from
8c7b75e to
de72cee
Compare
- Add bound checks to string manipulations - Add tag APIs to handle string views
r1viollet
commented
Jun 28, 2023
nsavoire
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes it safer and ensures a proper error message is surfaced to users.
Some of the options are now considered as flags (no longer require a boolean value to be given):
Example:
Motivation
ddprof's help was too complicated.This was not documented. I'm adding a basic documentation of events.
Additional Notes
This will require users to adjust some of their command lines
How to test the change?
I re-adjusted all the unit tests to the new code paths.
Downstream test PR
https://github.com/DataDog/ddprof-build/pull/100