Ensure that temporary process exits normally #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
force-pushed
the
nsavoire/ensure_cleanup_in_temp_pid
branch
from
5c1d940 to
058db25
Compare
|
CI seems to be KO :-), This seems like a cleaner approach! |
Killing the temporary intermediate process generates false memory leak reports in valgrind because some resources are not cleaned up (eg. local strings on the stack). The fix is to install a sigterm handler in temp pid, and upon receiving SIGTERM, make temp pid exits normally through main.
nsavoire
force-pushed
the
nsavoire/ensure_cleanup_in_temp_pid
branch
from
058db25 to
b39fe36
Compare
No idea what was going on with CI. Seems OK after rebase. |
r1viollet
reviewed
May 22, 2023
|
|
||
| struct sigaction sa; | ||
| if (sigemptyset(&sa.sa_mask) == -1) { | ||
| exit(1); |
There was a problem hiding this comment.
Minor: we should define a library logger for these cases.
r1viollet
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Killing the temporary intermediate process generates false memory leak reports in valgrind because some resources are not cleaned up (eg. local strings on the stack).
The fix is to install a sigterm handler in temp pid, and upon receiving SIGTERM, make temp pid exits normally through main.