Fix segfault on arm64 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
force-pushed
the
nsavoire/fix_arm64_segfault
branch
from
91a7be0 to
d2ebe23
Compare
sanchda
approved these changes
May 12, 2023
sanchda
previously approved these changes
May 12, 2023
|
Thanks for the fix! |
On arm64, pthread_attr_t is bigger in glibc than in musl. Consequently when pthread_getattr_np zeroes the struct, it writes out-of-bounds. Dirty fix is to add some padding at the end of the struct, this works because additional space present in glibc is not actually used.
nsavoire
force-pushed
the
nsavoire/fix_arm64_segfault
branch
from
d2ebe23 to
38e8dcf
Compare
r1viollet
reviewed
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On arm64, pthread_attr_t is bigger in glibc than in musl. Consequently when pthread_getattr_np zeroes the struct, it writes out-of-bounds.
Dirty fix is to add some padding at the end of the struct, this works because additional space present in glibc is not actually used.