Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo - set private field - add some missing includes #234

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Fix typo - set private field - add some missing includes #234

merged 3 commits into from
Mar 23, 2023

Conversation

sjanel
Copy link
Contributor

@sjanel sjanel commented Mar 23, 2023 •
edited
Loading

Remove extra ';'
Set kInvalidSocket private, removed inline (static constexpr implies inline)
Add missing includes

@sjanel sjanel changed the title Chore/minor clean up 1 Fix typo - set private field - add some missing includes Mar 23, 2023
nsavoire
nsavoire approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@nsavoire nsavoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Thanks for the contribution ;)

@nsavoire nsavoire merged commit 6a55fbd into DataDog:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsavoire nsavoire nsavoire approved these changes

@sanchda sanchda Awaiting requested review from sanchda sanchda is a code owner

@r1viollet r1viollet Awaiting requested review from r1viollet r1viollet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjanel @nsavoire