Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[APPSEC-56614] Add Instrumentation::Gateway#pushed? method"" #4467

Conversation

Strech
Copy link
Member

@Strech Strech commented Mar 6, 2025

Reverts #4465

Change log entry

No.

@Strech Strech requested a review from a team as a code owner March 6, 2025 15:14
@github-actions github-actions bot added the appsec Application Security monitoring product label Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-03-06 15:16:16 UTC

@Strech Strech added the dev/internal Other internal work that does not need to be included in the changelog label Mar 6, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: revert-4465-revert-4459-appsec-56614-track-triggered-instrumentation-events
Commit report: 716ebed
Test service: dd-trace-rb

✅ 0 Failed, 20797 Passed, 1370 Skipped, 3m 18.6s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (5701a10) to head (716ebed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4467      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files        1375     1376       +1     
  Lines       83812    83825      +13     
  Branches     4251     4251              
==========================================
+ Hits        81880    81892      +12     
- Misses       1932     1933       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2025

Benchmarks

Benchmark execution time: 2025-03-06 15:38:27

Comparing candidate commit 716ebed in PR branch revert-4465-revert-4459-appsec-56614-track-triggered-instrumentation-events with baseline commit 5701a10 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@Strech Strech enabled auto-merge March 6, 2025 15:38
@Strech Strech merged commit fb1935b into master Mar 6, 2025
483 checks passed
@Strech Strech deleted the revert-4465-revert-4459-appsec-56614-track-triggered-instrumentation-events branch March 6, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants