Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-3568 remove agent settings defaulting hack #4440

Merged
merged 5 commits into from
Mar 4, 2025
Merged

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Feb 26, 2025

What does this PR do?

Removes the agent settings defaulting hack from the codebase. Agent settings should be passed down from component construction into transports in order to respect user configuration.

Motivation:
Continued DRY refactoring of transport code to support dynamic instrumentation

Change log entry
None

Additional Notes:
I think this PR does not affect customers but not entirely sure.

I would like to remove transport_options in a subsequent PR.

How to test the change?
Existing unit tests

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-03-03 15:46:10 UTC

@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2025

Benchmarks

Benchmark execution time: 2025-03-01 06:03:06

Comparing candidate commit c12ab3e in PR branch transport-dry-2 with baseline commit 987b7a6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 26, 2025

Datadog Report

Branch report: transport-dry-2
Commit report: c12ab3e
Test service: dd-trace-rb

✅ 0 Failed, 20622 Passed, 1370 Skipped, 3m 11.63s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.69%. Comparing base (987b7a6) to head (c12ab3e).

Files with missing lines Patch % Lines
spec/datadog/tracing/transport/http_spec.rb 83.33% 2 Missing ⚠️
lib/datadog/tracing/workers/trace_writer.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4440      +/-   ##
==========================================
- Coverage   97.70%   97.69%   -0.01%     
==========================================
  Files        1374     1374              
  Lines       83807    83815       +8     
  Branches     4249     4251       +2     
==========================================
+ Hits        81882    81886       +4     
- Misses       1925     1929       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-datadog p-datadog changed the title DRY transport adapter registration 2 DEBUG-3568 remove agent settings defaulting hack Mar 1, 2025
@p-datadog p-datadog marked this pull request as ready for review March 3, 2025 15:46
@p-datadog p-datadog requested review from a team as code owners March 3, 2025 15:46
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way! This is an awesome clean up that always looked so ugly! 🙏

@p-datadog p-datadog merged commit 4fbd11b into master Mar 4, 2025
481 checks passed
@p-datadog p-datadog deleted the transport-dry-2 branch March 4, 2025 15:08
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants