-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-3568 remove agent settings defaulting hack #4440
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-03-03 15:46:10 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 20622 Passed, 1370 Skipped, 3m 11.63s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4440 +/- ##
==========================================
- Coverage 97.70% 97.69% -0.01%
==========================================
Files 1374 1374
Lines 83807 83815 +8
Branches 4249 4251 +2
==========================================
+ Hits 81882 81886 +4
- Misses 1925 1929 +4 ☔ View full report in Codecov by Sentry. |
7ff40e3
to
04ffc84
Compare
04ffc84
to
c12ab3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No way! This is an awesome clean up that always looked so ugly! 🙏
What does this PR do?
Removes the agent settings defaulting hack from the codebase. Agent settings should be passed down from component construction into transports in order to respect user configuration.
Motivation:
Continued DRY refactoring of transport code to support dynamic instrumentation
Change log entry
None
Additional Notes:
I think this PR does not affect customers but not entirely sure.
I would like to remove
transport_options
in a subsequent PR.How to test the change?
Existing unit tests