-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RestClient instrumentation for SSRF detection #4424
Conversation
BenchmarksBenchmark execution time: 2025-02-24 12:13:50 Comparing candidate commit a632a16 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Datadog ReportBranch report: ✅ 0 Failed, 20612 Passed, 1375 Skipped, 3m 21.69s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4424 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.01%
==========================================
Files 1363 1368 +5
Lines 83309 83438 +129
Branches 4217 4220 +3
==========================================
+ Hits 81418 81543 +125
- Misses 1891 1895 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
P.S I would consider few adjustments to tests and ask Tony about the Matrixfile
f8b49c5
to
49978b9
Compare
What does this PR do?
It adds SSRF detection for
rest-client
gem.To enable
rest-client
AppSec instrumentation:Motivation:
We want to add SSRF detection to more http client libraries.
Change log entry
Yes. AppSec: Add detection of Server-Side Request Forgery attacks for rest-client http client.
Additional Notes:
None.
How to test the change?
CI and app-generator (rails-ssrf application)