Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-3535 DRY Transport::HTTP::Builder, move to core #4413

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Feb 19, 2025

What does this PR do?

Combines Tracing and Remote Config HTTP builders into one and moves it into core.

Motivation:

DI requires UDS transport which would have involved copying the existing transports, in particular adding a third copy of the Builder. Since the builders are almost identical I decided to DRY up the existing ones so that we would only need one.

Change log entry
None

Additional Notes:

How to test the change?
Existing unit tests

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Feb 19, 2025
Copy link

github-actions bot commented Feb 19, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-19 22:18:07 UTC

@p-datadog p-datadog force-pushed the di-uds branch 3 times, most recently from 3fc731d to 14375fb Compare February 19, 2025 21:44
@p-datadog p-datadog added this to the 2.11.0 milestone Feb 19, 2025
@p-datadog p-datadog force-pushed the di-uds branch 2 times, most recently from dfaa7f5 to b2bf417 Compare February 19, 2025 21:52
@pr-commenter
Copy link

pr-commenter bot commented Feb 19, 2025

Benchmarks

Benchmark execution time: 2025-02-19 22:43:41

Comparing candidate commit 4b5aa20 in PR branch di-uds with baseline commit 2df231f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 19, 2025

Datadog Report

Branch report: di-uds
Commit report: 4b5aa20
Test service: dd-trace-rb

✅ 0 Failed, 20604 Passed, 1371 Skipped, 3m 19.22s Total Time

@p-datadog p-datadog marked this pull request as ready for review February 19, 2025 22:17
@p-datadog p-datadog requested review from a team as code owners February 19, 2025 22:17
@p-datadog p-datadog merged commit 917747b into master Feb 20, 2025
281 checks passed
@p-datadog p-datadog deleted the di-uds branch February 20, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants