[NO-TICKET] Switch libdatadog-crashtracking-receiver checks to wait_for #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR changes the crashtracking specs to use `wait_for` when asserting on the `libdatadog-crashtracking-receiver` process still being alive or not. **Motivation:** While experimenting with moving our test suite to GitHub Actions, this seemed to trigger a lot. Also, we saw it trigger at least once for CircleCI as well: https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/15402/workflows/d3d6f9ad-7d9f-4845-9f6b-bc92eaf88b74/jobs/563014 **Additional Notes:** Fixes DataDog/ruby-guild#176 . I'll see if there's something we can improve on the libdatadog side to avoid this flakiness, but let's not live with the flaky specs until we do so. **How to test the change?** Validate that CI is still green.
anmarchenko
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the crashtracking specs to use
wait_forwhen asserting on thelibdatadog-crashtracking-receiverprocess still being alive or not.Motivation:
While experimenting with moving our test suite to GitHub Actions, this seemed to trigger a lot.
Also, we saw it trigger at least once for CircleCI as well: https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/15402/workflows/d3d6f9ad-7d9f-4845-9f6b-bc92eaf88b74/jobs/563014
Additional Notes:
Fixes https://github.com/DataDog/ruby-guild/issues/176 .
I'll see if there's something we can improve on the libdatadog side to avoid this flakiness, but let's not live with the flaky specs until we do so.
How to test the change?
Validate that CI is still green.