Upgrade to libdatadog 0.8.0.1.0 #2240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This latest version brings a lot of renames to clean up the last remnants of the library being called libddprof instead of libdatadog. This PR only updates our code to use the new names, and otherwise behavior is unchanged (and all specs are still passing).
ivoanjo
force-pushed
the
ivoanjo/upgrade-to-libdatadog-0.8.0
branch
from
3ee7acb to
61362e8
Compare
|
Currently blocked by DataDog/libdatadog#47 |
|
The fix for DataDog/libdatadog#47 is going to be in libdatadog 0.9, and there's a few API changes to be included as well, so I'm going to close off this PR and re-open a new one to upgrade to 0.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Upgrade dd-trace-rb to use the latest libdatadog release.
This latest version brings a lot of renames to clean up the last
remnants of the library being called libddprof instead of libdatadog.
This PR only updates our code to use the new names, and otherwise
behavior is unchanged (and all specs are still passing).
Motivation:
The 0.8.0 includes at least one new feature that will be needed in the new Ruby profiler.
Additional Notes:
I am opening this as a draft PR until libdatadog 0.8.0 gets released on Rubygems.org.
This can already be tested locally as described in DataDog/libdatadog#44.
Also, we may want to wait until after the dd-trace-rb 1.4.0 release goes out to merge this PR.
How to test the change?:
Because this PR doesn't really change any behavior, our existing test suite should be enough to validate that things remain working (and it's green for me locally -- it should become green in CI once libdatadog gets released on rubygems.org).