Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): small apisec refactor #9535

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Jun 13, 2024

move api security logic to asm config

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jun 13, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 13, 2024

Datadog Report

Branch report: christophe-papazian/small_apisec_refactor
Commit report: 2c07867
Test service: dd-trace-py

✅ 0 Failed, 174751 Passed, 3529 Skipped, 11h 3m 57.69s Total duration (4m 17.28s time saved)

@christophe-papazian christophe-papazian marked this pull request as ready for review June 13, 2024 12:02
@christophe-papazian christophe-papazian requested a review from a team as a code owner June 13, 2024 12:02
@christophe-papazian christophe-papazian enabled auto-merge (squash) June 13, 2024 12:03
@christophe-papazian christophe-papazian merged commit c7931a7 into main Jun 13, 2024
228 of 242 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/small_apisec_refactor branch June 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants