[dev/tooling] Enforce single quote strings #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
approved these changes
Apr 15, 2019
|
@Kyle-Verhoog you are my hero! @jd yeah, I've been trying to keep consistent on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally this PR adds a
flake8plugin (https://github.com/zheller/flake8-quotes) to enforce single quote usage.This removes the dependency we had on the
brettlinter😄.This PR also replaces double quote strings with the corresponding single quote string. Strings containing single quotes remained untouched (which is permitted in the plugin https://github.com/zheller/flake8-quotes#caveats). We may want to figure out our convention for these cases.
Note: update branch to
masteronce #881 has been merged.