-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Use DEBUG log level for RateSampler initialization #861
[core] Use DEBUG log level for RateSampler initialization #861
Conversation
This way these logs can be seen when debugging is turned on, but otherwise left out.
I've never used tox before, but the
That fails the |
This way these logs can be seen when debugging is turned on, but otherwise left out.
…-py into rate-sampler-log-level
Now it's got a
|
There's a |
@jd It looks like the test failed again; not sure what I should do here? |
I've switched the target branch to |
Looks like a flaky integration test this time 😢 |
Yes that's #859 — I've reran the failed job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very reason change. Thanks @bmurphey for this!!!
Fixes #860 |
In reference to this issue.
This way these logs can be seen when debugging is turned on, but otherwise left out.