Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Fix requests gevent tests #854

Merged
merged 3 commits into from
Mar 20, 2019
Merged

[tests] Fix requests gevent tests #854

merged 3 commits into from
Mar 20, 2019

Conversation

brettlangdon
Copy link
Member

We were getting connection issues with https://icanhazip.com/ moved to https://httpbin.org/get

Also had to remove the httpbin_local container since we would try to hit that instead of the real server, and we need https for the tests to work.

@brettlangdon brettlangdon added this to the 0.24.0 milestone Mar 20, 2019
@brettlangdon brettlangdon requested a review from a team as a code owner March 20, 2019 14:22
@brettlangdon brettlangdon merged commit 8ade9b3 into 0.24-dev Mar 20, 2019
@brettlangdon brettlangdon deleted the brettlangdon/fix.requests.gevent branch March 20, 2019 14:27
@majorgreys majorgreys mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
1 participant
@brettlangdon