-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for python 3.12 #6626
Conversation
988c7bc
to
d0fe3ba
Compare
BenchmarksBenchmark execution time: 2023-09-08 19:44:02 Comparing candidate commit 57317e6 in PR branch Found 0 performance improvements and 13 performance regressions! Performance is the same for 91 metrics, 0 unstable metrics. scenario:flasksimple-baseline
scenario:flasksimple-debugger
scenario:flasksimple-iast-get
scenario:flasksimple-profiler
scenario:flasksimple-tracer
scenario:otelspan-start-finish
scenario:sethttpmeta-collectipvariant_exists
scenario:sethttpmeta-obfuscation-send-querystring-disabled
scenario:sethttpmeta-obfuscation-worst-case-explicit-query
scenario:sethttpmeta-obfuscation-worst-case-implicit-query
scenario:sethttpmeta-useragentvariant_exists_1
scenario:span-start-finish
|
eb9d907
to
868ef36
Compare
b59b9a4
to
3052251
Compare
df6cbaf
to
95a2c3b
Compare
49a3ea6
to
3cd8cd2
Compare
2822659
to
60e25bf
Compare
80b68c0
to
9a049f6
Compare
3d60ab8
to
d7f25b0
Compare
6fd9f52
to
c98489c
Compare
6848651
to
9869ad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make sure we don't remove tests that are still relevant
e85c602
to
919f560
Compare
@ZStriker19 @P403n1x87 @majorgreys @shatzi @Kyle-Verhoog This is actually ready for review now, with all tests passing. Please approve again at your convenience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits and questions. I think this needs a new rebase, otherwise LGTM!
Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com>
Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com>
@P403n1x87 thanks for checking this out. what do you mean by "needs a new rebase"? |
Oh sorry, I should have said that the target branch probably needs a new rebase as I think some changes are also available in 1.x at the moment, but still show up as diff in this PR (e.g. ddtrace/debugging/_expressions.py should have no diffs now that #6835 is merged in 1.x) |
@P403n1x87 ah, thanks for clarifying. do you know of any reason that needs to happen before this gets merged? |
Adds support for Python 3.12. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <gabriele.tornetta@datadoghq.com> Co-authored-by: Emmett Butler <emmett.butler321@gmail.com> Co-authored-by: ZStriker19 <zach.groves@datadoghq.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Adds support for Python 3.12. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <gabriele.tornetta@datadoghq.com> Co-authored-by: Emmett Butler <emmett.butler321@gmail.com> Co-authored-by: ZStriker19 <zach.groves@datadoghq.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Adds support for Python 3.12.
Checklist
changelog/no-changelog
.Reviewer Checklist