Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): improve iast scripts #10902

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Oct 2, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added the ASM Application Security Monitoring label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/__init__.py                                        @DataDog/asm-python
ddtrace/internal/module.py                                              @DataDog/debugger-python @DataDog/apm-core-python
hatch.toml                                                              @DataDog/python-guild
scripts/iast/README                                                     @DataDog/asm-python
scripts/iast/mod_leak_functions.py                                      @DataDog/asm-python
scripts/iast/requirements.txt                                           @DataDog/asm-python
scripts/iast/run_memory.sh                                              @DataDog/asm-python
scripts/iast/run_memray.sh                                              @DataDog/asm-python
scripts/iast/run_references.sh                                          @DataDog/asm-python
scripts/iast/test_references.py                                         @DataDog/asm-python
tests/appsec/iast_aggregated_memcheck/test_aggregated_memleaks.py       @DataDog/asm-python
scripts/iast/leak_functions.py                                          @DataDog/asm-python

scripts/iast/leak_functions.py Outdated Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Show resolved Hide resolved
scripts/iast/mod_leak_functions.py Outdated Show resolved Hide resolved
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 2, 2024

Datadog Report

Branch report: avara1986/iast_script_improvements
Commit report: 416b2a6
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 20m 13.82s Total duration (16m 18.25s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024

Benchmarks

Benchmark execution time: 2024-10-02 13:13:01

Comparing candidate commit 416b2a6 in PR branch avara1986/iast_script_improvements with baseline commit b0e1d82 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant