Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): code provenance using libdatadog exporter [backport-2.12] #10894

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Oct 1, 2024

Manual backport of #10796 to 2.12

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested review from a team as code owners October 1, 2024 20:48
@taegyunkim taegyunkim added the Profiling Continous Profling label Oct 1, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 1, 2024

Datadog Report

Branch report: backport-10796-to-2.12
Commit report: 0ce3f13
Test service: dd-trace-py

✅ 0 Failed, 411 Passed, 3399 Skipped, 34m 20.84s Total duration (1h 7m 24.03s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024

Benchmarks

Benchmark execution time: 2024-10-02 00:21:14

Comparing candidate commit 0ce3f13 in PR branch backport-10796-to-2.12 with baseline commit 3a85912 in branch 2.12.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@taegyunkim taegyunkim enabled auto-merge (squash) October 2, 2024 13:40
@taegyunkim taegyunkim merged commit 2ea5415 into 2.12 Oct 2, 2024
256 of 258 checks passed
@taegyunkim taegyunkim deleted the backport-10796-to-2.12 branch October 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants