Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): improve SSI behavior and error messages for profiling #10807

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Sep 25, 2024

We've discovered in some autoinject configurations profiling and crashtracking can fail to work because the packaging system over-writes libdd_wrapper.so with one from the wrong arch.

I'm setting a very wide backport range because this has significant implications (possibility of segmentation faults and service failures when erroneously loading protobuf in injected environments)

This patch

  • Improves the error message when libdd_wrapper fails to load in profiling
  • Disables profiling when such a condition is encountered in an injected environment

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-fix-autoinject-failure-48cc7d9a18cd70b9.yaml  @DataDog/apm-python
ddtrace/profiling/profiler.py                                           @DataDog/profiling-python

@sanchda sanchda enabled auto-merge (squash) September 30, 2024 15:30
@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024

Benchmarks

Benchmark execution time: 2024-10-01 16:06:54

Comparing candidate commit 9708759 in PR branch sanchda/add_libdd_load_failure_msg with baseline commit 7f6f3db in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 372 metrics, 52 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants