Skip to content

Commit

Permalink
fix: add encodings.idna to the denylist [backport 2.9] (#9886)
Browse files Browse the repository at this point in the history
Backport 185076f from #9873 to 2.9.

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Juanjo Alvarez Martinez <juanjo.alvarezmartinez@datadoghq.com>
  • Loading branch information
github-actions[bot] and juanjux authored Jul 22, 2024
1 parent ccc9a4f commit 94fe5ff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions ddtrace/appsec/_iast/_ast/ast_patching.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"ddsketch",
"ddtrace",
"encodings", # this package is used to load encodings when a module is imported, propagation is not needed
"encodings.idna",
"envier",
"exceptiongroup",
"freezegun", # Testing utilities for time manipulation
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/asm-avoid-idna-d724dce73afafa93.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
Code Security: add encodings.idna to the IAST patching denylist to avoid problems with gevent.

0 comments on commit 94fe5ff

Please sign in to comment.