Fix Predis integration for clusters #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaoulMeyer
force-pushed
the
fix-predis-cluster-integration
branch
3 times, most recently
from
d6002bb to
f68ef92
Compare
RaoulMeyer
force-pushed
the
fix-predis-cluster-integration
branch
from
f68ef92 to
af60be3
Compare
|
Thank you so much for this fix @RaoulMeyer! I'll make sure we get this reviewed this week so that we can roll it into a release as soon as possible. :) |
SammyK
added
🏘 community
SammyK
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
Excellent work @RaoulMeyer! Thank you so much for taking the time to submit a PR. We will get this rolled into the next release. :)
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Predis integration makes our application crash when enabling APM (see issue #315). Because the interface that Predis provides doesn't allow getting the connection details for a cluster, in this PR I've removed the host and port tags for clusters. This also makes the retrieving of host and port a bit cleaner.
Readiness checklist
Reviewer checklist