Handle MasterSlaveReplication connections #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, so I might have forgot PHP 5 - will replace the ?? :) |
5 tasks
|
I'm closing this as it no longer looks applicable, and would appear to be stale. If I'm wrong to do that, please open a new PR, and accept my apologies in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, DD causes errors in some situations when using predis/predis, when predis is using master-slave replication. This was discussed in #315
There may be a couple of points of discussion around this:
What should happen when
Client::getConnection()returns aMasterSlaveReplicationconnection, but the connection hasn't been used yet, soMasterSlaveReplication::connectionis empty. In our use case (and thus in this PR) we ask it to return the master, but this might not be preferred behaviour?I looked at writing a test to cover this, but I was struggling to get my head around how your tests work, and I couldn't actually create a breaking test in the first place to fix! If someone can point me in the right direction @SammyK @pawelchcki the I'll take another look at getting a test to play nice!!