Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ZTS build for backtrace and logging functions #309

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

pawelchcki
Copy link
Contributor

Description

Readiness checklist

@pawelchcki pawelchcki force-pushed the fix_master_compilation branch from 4220069 to cf3d86b Compare February 18, 2019 18:06
labbati
labbati previously approved these changes Feb 18, 2019
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me!

@pawelchcki pawelchcki force-pushed the fix_master_compilation branch from b8266a1 to fe27353 Compare February 18, 2019 18:15
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as the failing 5.4 test is a known flaky test addressed in https://github.com/DataDog/dd-trace-php/tree/labbati/detailed-error-log-autoinstrumentation

@pawelchcki pawelchcki merged commit 3e62f56 into master Feb 18, 2019
@pawelchcki pawelchcki deleted the fix_master_compilation branch February 18, 2019 18:44
estringana pushed a commit that referenced this pull request Dec 4, 2023
…access with php-fpm (#309)

* Upgrade tracer to fix ZAI config handling for .htaccess with php-fpm

* Release v0.14.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants