[ci] In CI disable tls check for 5.4 only to avoid Peer fingerprint mismatch #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very often php 5.4 tests were failing with this same error. Apparently the reason is PHP 5.4 having some issues with tls verification (https://github.com/composer/composer/blob/master/src/Composer/Util/RemoteFilesystem.php#L354). The solution proposed here is to disable tls only when downloading libraries using composer for php 5.4. This has no security implications as this is only done for tests execution and not during package build.
Readiness checklist
[ ] Changelog entry added, if necessary[ ] Tests added for this feature/bug