Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of appsec helper with llvm's linker #3069

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

cataphract
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.02%. Comparing base (01b46dd) to head (80904a0).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3069      +/-   ##
============================================
- Coverage     74.77%   73.02%   -1.76%     
  Complexity     2787     2787              
============================================
  Files           112      139      +27     
  Lines         11033    15272    +4239     
  Branches          0     1043    +1043     
============================================
+ Hits           8250    11152    +2902     
- Misses         2783     3569     +786     
- Partials          0      551     +551     
Flag Coverage Δ
appsec-extension 68.41% <ø> (?)
tracer-php 74.79% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b46dd...80904a0. Read the comment docs.

@cataphract cataphract merged commit 9cc3c1f into master Feb 6, 2025
693 of 720 checks passed
@cataphract cataphract deleted the glopes/fix-lld-helper branch February 6, 2025 13:38
@github-actions github-actions bot added this to the 1.7.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants