fix: ObjectKVStore::put
on throwing __set
#3066
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
predis/predis
, starting v2.1.2 w/ predis/predis#1049, it is no longer possible to use ObjectKVStore::put in versions 7.4 and below since Predis\Client::__set will be throwing an exception.Currently, PredisIntegration is throwing an exception on versions 2.1.2+, using a PHP runtime that is strictly less than 7.4. Current estimates are reporting that ~5% of orgs using the predis integration are impacted.
Description
Fallback to spl_object_hash when it is not possible to use the weakmap nor
__set
.This should allow to proceed with #3065.
Reviewer checklist