-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIDM-455: Generate Markdown Table of Supported Versions #3062
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3062 +/- ##
=============================================
- Coverage 74.74% 56.45% -18.30%
Complexity 2790 2790
=============================================
Files 112 139 +27
Lines 11039 15273 +4234
Branches 0 1043 +1043
=============================================
+ Hits 8251 8622 +371
- Misses 2788 6100 +3312
- Partials 0 551 +551
Flags with carried forward coverage won't be shown. Click here to find out more. see 48 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done and thanks for the PR description!
I think we can refine the generated table a bit at a later date as there seem to be some tricky integrations to report here.
| symfony/messenger | 4.4.49 | 7.2.1 | | ||
| wordpress | 4.8.10 | 6.1.1 | | ||
| yiisoft/yii2 | 2.0.49 | 2.0.51 | | ||
| zendframework/zf1 | 1.12.20 | 1.12.20 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there is a Zend Framework
V2 https://docs.datadoghq.com/tracing/trace_collection/compatibility/php
But that is Generic web tracing
would that mean that it is supported via HTTP call instrumentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PHP Tracer will automatically generate a web.request
root span for all incoming HTTP requests. Without further instrumentation, this is what is being called "Generic Web Tracing" for the PHP Tracer, meaning that transactions will be traced, as well as hypothetical Database calls (for instance).
On the other hand, "Framework-Level Instrumentation" offers greater information granularity based on the framework's specifics. For instance, for a MVC based framework, this would mean at least tracing the controller.
In the case of ZF2, we don't have a specific instrumentation. However, I believe that since it used to be a common PHP framework, it was included in the documentation so as to indicate that we provide some sort of support for it.
Does that answer your question? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep exactly does thanks!
Wondering how we best would like to represent these types of instrumentations as we have several instances here and in others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll bring that question up to figure out a path, but nothing to do at the moment unless you have ideas 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the ones that aren't here but I think should be from looking at https://docs.datadoghq.com/tracing/trace_collection/compatibility/php
e.g. curl
and zendframework v2
I think my understanding is that there isn't a nice way to fit these in here, so it may require some manual effort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had forgotten adding curl. My bad. However for zf2, it would indeed require manual effort.
43a1fd9
to
4a02531
Compare
4a02531
to
ebf195a
Compare
Description
Akin to what has been made on other tracing repositories, a full record of tested versions and a markdown table of min/max supported versions will be automatically kept up to date.
A new CircleCI Job
aggregate_tested_versions
has been added. The latter will run on every commit made to master. It will be in charge to collect tested_versions.json artifacts from CircleCI test jobs, aggregate them, and generate a PR if necessary.A sample PR can be seen at the following link: #3060 - (CircleCI Job).
Note that two environment variables have been added to CircleCI's settings:
CIRCLECI_TOKEN
andGITHUB_TOKEN
. They are used to communicate with CircleCI's and Github's APIs, respectively.As such, two "repository artifacts" will be added at the root of the repo: aggregated_tested_versions.json and integration_versions.md. The former contains all tested versions of target libraries, while the latter summarize min/max supported versions.
To record tested versions, a method
recordTestedVersion
will be called during tests' tear down.laravel/framework
or **ext-**redis) will have to be specified by overridinggetTestedLibrary
.getTestedLibrary
andgetTestedVersion
with the tested library/version.The
tested_versions
Makefie target will always be run at the end ofintegration-snapshots
jobs, and generate the aforementionedtested_versions.json
artifact.Reviewer checklist