-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rasp telemetry #3061
Add rasp telemetry #3061
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (37.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #3061 +/- ##
=============================================
- Coverage 72.97% 56.41% -16.56%
Complexity 2790 2790
=============================================
Files 139 139
Lines 15273 15280 +7
Branches 1043 1047 +4
=============================================
- Hits 11145 8620 -2525
- Misses 3577 6107 +2530
- Partials 551 553 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
5dd1562
to
0627472
Compare
...c/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/TelemetryTests.groovy
Show resolved
Hide resolved
...c/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/TelemetryTests.groovy
Outdated
Show resolved
Hide resolved
My earlier comment encompassed all the quoted code. You don't need to prepare an RC message enabling ASM and sending a request to force the helper to start. |
for (auto const &rule : rasp_metrics_) { | ||
metrics::telemetry_tags tags; | ||
tags.add("rule_type", rule.first); | ||
tags.add("waf_version", ddwaf_get_version()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two other tags (newly defined) that are missing:
event_rules_version
block
(only forrasp.rule.match
)
Description
Add rasp telemetry metrics
APPSEC-52938
Reviewer checklist