Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UserAvailableConstantsTest::testAllTypesAreTested #3042

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

PROFeNoM
Copy link
Contributor

Description

This will fix test_api_unit failures currently happening on master.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Jan 17, 2025
@PROFeNoM PROFeNoM requested a review from a team as a code owner January 17, 2025 09:52
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (9aa53e7) to head (7255363).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3042      +/-   ##
============================================
+ Coverage     67.03%   74.80%   +7.76%     
  Complexity     2784     2784              
============================================
  Files           139      112      -27     
  Lines         15169    11020    -4149     
  Branches       1022        0    -1022     
============================================
- Hits          10169     8243    -1926     
+ Misses         4448     2777    -1671     
+ Partials        552        0     -552     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.80% <ø> (+8.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa53e7...7255363. Read the comment docs.

@PROFeNoM PROFeNoM merged commit dfce9d8 into master Jan 17, 2025
647 of 689 checks passed
@PROFeNoM PROFeNoM deleted the alex/fix/testAllTypesAreTested-Jan17 branch January 17, 2025 12:00
@github-actions github-actions bot added this to the 1.7.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants