-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PHP Installer Tests #3016
fix: PHP Installer Tests #3016
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3016 +/- ##
============================================
+ Coverage 72.45% 74.80% +2.35%
Complexity 2781 2781
============================================
Files 139 112 -27
Lines 15177 11017 -4160
Branches 1026 0 -1026
============================================
- Hits 10996 8241 -2755
+ Misses 3622 2776 -846
+ Partials 559 0 -559
Flags with carried forward coverage won't be shown. Click here to find out more. see 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
'php56-fpm', | ||
'php5.6-fpm', | ||
'php-fpm56', | ||
'php-fpm5.6', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, though better to replace it by 8.4 - the point is to test the patterns.
34b03a1
to
23ef96c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Description
Integration tests are failing (Sample Failure):
Reviewer checklist