Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PHP Installer Tests #3016

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: PHP Installer Tests #3016

merged 1 commit into from
Jan 6, 2025

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Jan 6, 2025

Description

Integration tests are failing (Sample Failure):

There were 2 failures:

1) DDTrace\Tests\Integration\PHPInstallerTest::testBuildCommandNamesMatrix
Failed asserting that an array contains 'php54'.

/home/circleci/datadog/tests/Integration/PHPInstallerTest.php:80

2) DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Failed asserting that an array has the key '/tmp/dd-php-setup-tests/opt/remi/php74/root/usr/sbin/php56-fpm'.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Jan 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (bd0a50f) to head (23ef96c).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3016      +/-   ##
============================================
+ Coverage     72.45%   74.80%   +2.35%     
  Complexity     2781     2781              
============================================
  Files           139      112      -27     
  Lines         15177    11017    -4160     
  Branches       1026        0    -1026     
============================================
- Hits          10996     8241    -2755     
+ Misses         3622     2776     -846     
+ Partials        559        0     -559     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.80% <ø> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0a50f...23ef96c. Read the comment docs.

Comment on lines -106 to -109
'php56-fpm',
'php5.6-fpm',
'php-fpm56',
'php-fpm5.6',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, though better to replace it by 8.4 - the point is to test the patterns.

@PROFeNoM PROFeNoM force-pushed the alex/fix/php-installer-test branch from 34b03a1 to 23ef96c Compare January 6, 2025 14:27
@PROFeNoM PROFeNoM marked this pull request as ready for review January 6, 2025 14:51
@PROFeNoM PROFeNoM requested a review from a team as a code owner January 6, 2025 14:51
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@PROFeNoM PROFeNoM merged commit 205c6d8 into master Jan 6, 2025
441 of 473 checks passed
@PROFeNoM PROFeNoM deleted the alex/fix/php-installer-test branch January 6, 2025 15:02
@github-actions github-actions bot added this to the 1.6.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants