Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave a hint at what to do if the temp dir is not writable in installer #3015

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Jan 3, 2025

Description

It's not always obvious to the user how to work around a permission denied error here.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi bwoebi requested a review from a team as a code owner January 3, 2025 12:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.90%. Comparing base (c69df0a) to head (c9714cb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3015      +/-   ##
============================================
+ Coverage     73.88%   73.90%   +0.01%     
  Complexity     2750     2750              
============================================
  Files           111      111              
  Lines         10900    10900              
============================================
+ Hits           8054     8056       +2     
+ Misses         2846     2844       -2     
Flag Coverage Δ
tracer-php 73.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69df0a...c9714cb. Read the comment docs.

@bwoebi bwoebi merged commit af73877 into master Jan 3, 2025
434 of 473 checks passed
@bwoebi bwoebi deleted the bob/tmpdir-not-writable branch January 3, 2025 13:19
@github-actions github-actions bot added this to the 1.6.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants