-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rust to 1.78 and add feature to Cargo.toml according to libdatadog changes #3005
Conversation
@dubloom You probably have to update the reference of the libdatadog submodule to make it work |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3005 +/- ##
=============================================
- Coverage 74.80% 38.62% -36.19%
Complexity 2781 2781
=============================================
Files 112 112
Lines 11017 11017
=============================================
- Hits 8241 4255 -3986
- Misses 2776 6762 +3986
Flags with carried forward coverage won't be shown. Click here to find out more. see 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ tracer ]Benchmark execution time: 2024-12-20 13:11:47 Comparing candidate commit aae29fb in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PDOBench/benchPDOBaseline
|
@@ -8,7 +8,7 @@ crate-type = ["staticlib", "cdylib"] | |||
path = "lib.rs" | |||
|
|||
[dependencies] | |||
ddcommon = { path = "../libdatadog/ddcommon" } | |||
ddcommon = { path = "../libdatadog/ddcommon", features = ["cgroup_testing"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for tests, you probably don't want this feature as a regular dependency. You can leave the ddcommon dependency as it was here, and under dev-dependencies add it again with this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i might do it wrong, but when i try, themake install
command will fail because set_cgroup_file is not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for tests, but for PHP extension tests. Which are (also) run on release builds.
e880898
to
5b1d482
Compare
Benchmarks [ profiler ]Benchmark execution time: 2025-01-06 16:32:50 Comparing candidate commit 39df479 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 26 metrics, 8 unstable metrics. scenario:walk_stack/50
scenario:walk_stack/99
|
5b1d482
to
2488f64
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
918efa2
to
dd16141
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Add SSRF Rasp capability (#814) Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
dd16141
to
39df479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on the profiling side 👍🏻
Description
libdatadog removed the set_cgroup_file feature. However it is used in some dd-trace-php tests. As we are not sure they can be removed and without any changes the tracer cannot be built, they added back but under a feature flag.
This PR activates the feature flag and therefore enable the tracer to be built again.
Reviewer checklist