Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add verfy php 8.4 #2987

Merged
merged 1 commit into from
Dec 11, 2024
Merged

ci: add verfy php 8.4 #2987

merged 1 commit into from
Dec 11, 2024

Conversation

realFlowControl
Copy link
Member

Description

This adds the missing verify checks for PHP 8.4.
Relates to #2984

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested a review from a team as a code owner December 9, 2024 09:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.90%. Comparing base (b0da77f) to head (7c44214).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2987   +/-   ##
=========================================
  Coverage     72.90%   72.90%           
  Complexity     2741     2741           
=========================================
  Files           137      137           
  Lines         14978    14978           
  Branches       1016     1016           
=========================================
  Hits          10920    10920           
  Misses         3506     3506           
  Partials        552      552           
Flag Coverage Δ
appsec-extension 67.84% <ø> (ø)
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0da77f...7c44214. Read the comment docs.

@realFlowControl realFlowControl merged commit 8273bb7 into master Dec 11, 2024
507 of 527 checks passed
@realFlowControl realFlowControl deleted the florian/add-verify-tests branch December 11, 2024 11:36
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants