-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Integrations): update user login and signup events collection #2976
feat(Integrations): update user login and signup events collection #2976
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2976 +/- ##
============================================
- Coverage 74.80% 73.02% -1.78%
- Complexity 2784 2787 +3
============================================
Files 112 139 +27
Lines 11020 15272 +4252
Branches 0 1043 +1043
============================================
+ Hits 8243 11152 +2909
- Misses 2777 3569 +792
- Partials 0 551 +551
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ tracer ]Benchmark execution time: 2025-01-06 16:46:28 Comparing candidate commit 5930a5e in PR branch Found 3 performance improvements and 2 performance regressions! Performance is the same for 173 metrics, 0 unstable metrics. scenario:HookBench/benchWithoutHook-opcache
scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache
scenario:LogsInjectionBench/benchLogsInfoInjection-opcache
scenario:LogsInjectionBench/benchLogsNullBaseline-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
95dcd66
to
22d8216
Compare
Benchmarks [ appsec ]Benchmark execution time: 2024-12-24 14:21:13 Comparing candidate commit 3df244c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
dfb19df
to
50499a4
Compare
2d3ddb4
to
ef44aac
Compare
ee0b645
to
99c0519
Compare
8296e70
to
3df244c
Compare
72f6119
to
8c2852e
Compare
bdf213e
to
7f63405
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the trailing commas are the reason for the failing tests in PHP 7.2 and earlier
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…p event Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
… failure event Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
… success event Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…n user events Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…nctions Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
e0b50b6
to
2cc1113
Compare
Co-authored-by: Alexandre Choura <42672104+PROFeNoM@users.noreply.github.com>
2cc1113
to
00c42f0
Compare
Description
Implement changes on user login and signup automated event collection according to the RFC.
The following changes have been implemented:
appsec.events.users.login.failure
andappsec.events.users.login.success
Reviewer checklist
Related Jiras: APPSEC-55606, APPSEC-55605, APPSEC-55604