Fix appsec tests in 8.1-8.3

[cataphract]

Description

The use of pipe() creates an extra file descriptor which makes the helper unable to find the correct pipe file descriptor. While this could perhaps be improved by telling the helper explicitly the id of the correct file descriptor, it's probably better to swap write() calls of reading invalid addresses with mincore().

See #2942 , which broke the tests

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (35d1665) to head (21dcf99).
Report is 22 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2974      +/-   ##
============================================
- Coverage     74.82%   74.80%   -0.02%     
  Complexity     2741     2741              
============================================
  Files           110      110              
  Lines         10863    10863              
============================================
- Hits           8128     8126       -2     
- Misses         2735     2737       +2     

Flag	Coverage Δ
tracer-php	74.80% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d1665...21dcf99. Read the comment docs.

[Anilm3]

The use of pipe() creates an extra file descriptor which makes the helper unable to find the correct pipe file descriptor. While this could perhaps be improved by telling the helper explicitly the id of the correct file descriptor, it's probably better to swap write() calls of reading invalid addresses with mincore().

I suppose you meant mock helper.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-26 22:04:27

Comparing candidate commit 21dcf99 in PR branch glopes/fix-appsec-test-pipe with baseline commit 35d1665 in branch master.

Found 2 performance improvements and 2 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

• 🟩 execution_time [-9.093µs; -6.707µs] or [-5.285%; -3.898%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟥 execution_time [+13.469µs; +18.769µs] or [+7.501%; +10.453%]

scenario:TraceFlushBench/benchFlushTrace

• 🟥 execution_time [+1000.000ns; +1000.000ns] or [+100.000%; +100.000%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟩 execution_time [-12.638µs; -7.162µs] or [-6.224%; -3.527%]

[Anilm3]

The linux logic looks good to me. Hopefully someone can double check the macos bit...